Improve .env discovery
#737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
nbarbettini
reviewed
Jan 13, 2026
| if env_path.exists(): | ||
| # Step 3: Load .env file if it exists (searches upward through parent directories) | ||
| console.print("\nSearching for .env file...", style="dim") | ||
| env_path = find_env_file() |
Collaborator
There was a problem hiding this comment.
What are the implications if this traverses very far up (say, ~/, or C:\ on Windows) and finds a random .env file? What could accidentally be in memory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves TOO-201
Documentation PR for this is here: ArcadeAI/docs#626
Note
Improves environment handling by discovering
.envfiles via upward traversal and wiring it through server and CLI flows.find_env_file()inarcade_mcp_server.settingsand use it inMCPSettings.from_env()for auto-loading.envMCPAppreload to watch.pyfiles and the discovered.env(even outsidecwd) and include it in watcher pathsconfigure.get_tool_secrets()now loads secrets from discovered.envdeploysearches for.env, loads it, and only uploads--secrets allwhen a file existsutils.resolve_provider_api_key()now searches upward for.env.env.exampleto project root with clear guidance.envdiscovery andconfigure.get_tool_secrets(); introduce env isolation fixture to prevent leakage between testsarcade-mcp-server→1.15.0;arcade-mcp→1.9.0and update dependency pins accordinglyWritten by Cursor Bugbot for commit 83cd2b3. This will update automatically on new commits. Configure here.